MAINT: Setup a pytest fixture for reuse across tests #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 77.63% 68.15% -9.49%
==========================================
Files 12 13 +1
Lines 921 942 +21
==========================================
- Hits 715 642 -73
- Misses 206 300 +94
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
So actually the dash tests are the real culprit for our test suite taking so long now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's taking a long time to run our test suite, and the reason is that in
test_pipeline, multiple tests are literally re running the entire pipeline (including two ICA's!) on a file that isn't really a test file to begin with (it's more than a minute long).This sets up a
pytestfixture so that we can just run this file through the pipeline once, and reuse it across all of our tests. This will be especially handy for #138 , because that PR is currently running the pipeline on a file yet another time for the rejection tests.On my local, the entire test suite is running less than 30 seconds. let's see this improves the testing time on the VM's.